django/daphne
1
1
Fork 0
mirror of https://github.com/django/daphne.git synced 2024-11-22 07:56:34 +03:00
Code Issues Packages Projects Releases Wiki Activity

Check query string for spec conformance again (#112)

Browse Source 
This check was skipped because of
https://github.com/django/daphne/issues/110. As this issue is now fixed,
we can re-enable the check again.
This commit is contained in:
Maik Hoepfel 2017-05-02 19:23:49 +02:00 committed by Andrew Godwin
parent a59bd123a9
commit 8787c1dfe2
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
daphne/tests/testcases.py
View File

@ -223,11 +223,8 @@ class ASGIWebSocketTestCase(ASGITestCaseBase):
query_string = channel_message.get('query_string') query_string = channel_message.get('query_string')
if query_string: if query_string:
# Assert that query_string is a byte string and still url encoded # Assert that query_string is a byte string and still url encoded
# TODO: It's neither a byte string nor urlencoded self.assertIsInstance(query_string, six.binary_type)
# Will fail until https://github.com/django/daphne/issues/110 is resolved. self.assertEqual(query_string, parse.urlencode(request_params or []).encode('ascii'))
#self.assertIsInstance(query_string, six.binary_type)
#self.assertEqual(query_string, parse.urlencode(request_params or []).encode('ascii'))
pass
root_path = channel_message.get('root_path') root_path = channel_message.get('root_path')
if root_path is not None: if root_path is not None: