encode/django-rest-framework
1
1
Fork 0
mirror of https://github.com/encode/django-rest-framework.git synced 2025-07-18 12:12:19 +03:00
Code Issues Packages Projects Releases Wiki Activity

fix formatting issues for list serializer validation fix

Browse Source
This commit is contained in:
Saadullah Aleem 2023-05-11 01:33:19 +05:00
parent a717d74f3c
commit 4bbc689ec5
2 changed files with 4 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
rest_framework/serializers.py
View File

@ -592,7 +592,7 @@ class ListSerializer(BaseSerializer):
if kwargs.get('instance', []) and kwargs.get('data', []): if kwargs.get('instance', []) and kwargs.get('data', []):
assert len(kwargs.get("data", [])) == len( assert len(kwargs.get("data", [])) == len(
kwargs.get("instance", [])), 'Data and instance should have same length' kwargs.get("instance", [])), 'Data and instance should have same length'
super().__init__(*args, **kwargs) super().__init__(*args, **kwargs)
self.child.bind(field_name='', parent=self) self.child.bind(field_name='', parent=self)

7
tests/test_serializer.py
View File

@ -2,6 +2,7 @@ import inspect
import pickle import pickle
import re import re
import sys import sys
import unittest
from collections import ChainMap from collections import ChainMap
from collections.abc import Mapping from collections.abc import Mapping
@ -10,7 +11,6 @@ from django.db import models
from rest_framework import exceptions, fields, relations, serializers from rest_framework import exceptions, fields, relations, serializers
from rest_framework.fields import Field from rest_framework.fields import Field
from .models import ( from .models import (
ForeignKeyTarget, NestedForeignKeySource, NullableForeignKeySource ForeignKeyTarget, NestedForeignKeySource, NullableForeignKeySource
) )
@ -787,9 +787,6 @@ class MyClassSerializer(serializers.ModelSerializer):
return value return value
import unittest
class TestMultipleObjectsValidation(unittest.TestCase): class TestMultipleObjectsValidation(unittest.TestCase):
def setUp(self): def setUp(self):
self.objs = [ self.objs = [
@ -818,7 +815,7 @@ class TestMultipleObjectsValidation(unittest.TestCase):
def test_exception_raised_when_data_and_instance_length_different(self): def test_exception_raised_when_data_and_instance_length_different(self):
with self.assertRaises(AssertionError): with self.assertRaises(AssertionError):
serializer = MyClassSerializer( MyClassSerializer(
data=[{'value': 'set', 'id': instance.id} for instance in data=[{'value': 'set', 'id': instance.id} for instance in
self.objs], self.objs],
instance=self.objs[:-1], instance=self.objs[:-1],