encode/django-rest-framework
1
1
Fork 0
mirror of https://github.com/encode/django-rest-framework.git synced 2025-05-22 21:46:08 +03:00
Code Issues Packages Projects Releases Wiki Activity

Drop HTML line breaks on long headers in browsable API (#9438)

Browse Source 
* Drop HTML line breaks on long headers

* Remove related test

* Fix flake8

---------

Co-authored-by: Asif Saif Uddin <auvipy@gmail.com>
Co-authored-by: Bruno Alla <alla.brunoo@gmail.com>
This commit is contained in:
Tom Christie 2025-04-28 05:08:48 +01:00 committed by GitHub
parent 376026ce35
commit 78e97074e7
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 3 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
rest_framework/templates/rest_framework/base.html
View File

@ -176,7 +176,7 @@
<div class="response-info" aria-label="{% trans "response info" %}"> <div class="response-info" aria-label="{% trans "response info" %}">
<pre class="prettyprint"><span class="meta nocode"><b>HTTP {{ response.status_code }} {{ response.status_text }}</b>{% for key, val in response_headers|items %} <pre class="prettyprint"><span class="meta nocode"><b>HTTP {{ response.status_code }} {{ response.status_text }}</b>{% for key, val in response_headers|items %}
<b>{{ key }}:</b> <span class="lit">{{ val|break_long_headers|urlize }}</span>{% endfor %} <b>{{ key }}:</b> <span class="lit">{{ val|urlize }}</span>{% endfor %}
</span>{{ content|urlize }}</pre> </span>{{ content|urlize }}</pre>
</div> </div>

11
rest_framework/templatetags/rest_framework.py
View File

@ -313,14 +313,3 @@ def smart_urlquote_wrapper(matched_url):
return smart_urlquote(matched_url) return smart_urlquote(matched_url)
except ValueError: except ValueError:
return None return None
@register.filter
def break_long_headers(header):
"""
Breaks headers longer than 160 characters (~page length)
when possible (are comma separated)
"""
if len(header) > 160 and ',' in header:
header = mark_safe('<br> ' + ', <br>'.join(escape(header).split(',')))
return header

9
tests/test_templatetags.py
View File

@ -8,8 +8,8 @@ from rest_framework.compat import coreapi, coreschema
from rest_framework.relations import Hyperlink from rest_framework.relations import Hyperlink
from rest_framework.templatetags import rest_framework from rest_framework.templatetags import rest_framework
from rest_framework.templatetags.rest_framework import ( from rest_framework.templatetags.rest_framework import (
add_nested_class, add_query_param, as_string, break_long_headers, add_nested_class, add_query_param, as_string, format_value,
format_value, get_pagination_html, schema_links get_pagination_html, schema_links
) )
from rest_framework.test import APIRequestFactory from rest_framework.test import APIRequestFactory
@ -234,11 +234,6 @@ class TemplateTagTests(TestCase):
get_pagination_html(pager) get_pagination_html(pager)
assert pager.called is True assert pager.called is True
def test_break_long_lines(self):
header = 'long test header,' * 20
expected_header = '<br> ' + ', <br>'.join(header.split(','))
assert break_long_headers(header) == expected_header
class Issue1386Tests(TestCase): class Issue1386Tests(TestCase):
""" """