encode/django-rest-framework
1
1
Fork 0
mirror of https://github.com/encode/django-rest-framework.git synced 2025-01-24 00:04:16 +03:00
Code Issues Packages Projects Releases Wiki Activity

Raise nicer exception if queryset not Set on writable related field. Refs: #338

Browse Source
This commit is contained in:
Tom Christie 2012-10-30 11:10:23 +00:00
parent 0047a46020
commit cea907f172
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
rest_framework/fields.py
View File

@ -291,6 +291,9 @@ class PrimaryKeyRelatedField(RelatedField):
return pk return pk
def from_native(self, data): def from_native(self, data):
if self.queryset is None:
raise Exception('Writable related fields must include a `queryset` argument')
try: try:
return self.queryset.get(pk=data) return self.queryset.get(pk=data)
except ObjectDoesNotExist: except ObjectDoesNotExist:
@ -374,6 +377,8 @@ class HyperlinkedRelatedField(RelatedField):
def from_native(self, value): def from_native(self, value):
# Convert URL -> model instance pk # Convert URL -> model instance pk
# TODO: Use values_list # TODO: Use values_list
if self.queryset is None:
raise Exception('Writable related fields must include a `queryset` argument')
if value.startswith('http:') or value.startswith('https:'): if value.startswith('http:') or value.startswith('https:'):
# If needed convert absolute URLs to relative path # If needed convert absolute URLs to relative path