🏷 Add Mypy check to CI and ignore all existing Mypy errors (#9167)
* 🚨 Ignore all existing Mypy errors
* 🏗 Add Mypy check to CI
* Add types-mock and types-requests as dev requirements
* Add additional type ignore directives
* Add types packages to dev-only list in reqs test
* Add types-dataclasses for python 3.6
* Add ignore to pretrain
* 🏷 Improve type annotation on `run_command` helper
The `run_command` helper previously declared that it returned an
`Optional[subprocess.CompletedProcess]`, but it isn't actually possible
for the function to return `None`. These changes modify the type
annotation of the `run_command` helper and remove all now-unnecessary
`# type: ignore` directives.
* 🔧 Allow variable type redefinition in limited contexts
These changes modify how Mypy is configured to allow variables to have
their type automatically redefined under certain conditions. The Mypy
documentation contains the following example:
```python
def process(items: List[str]) -> None:
# 'items' has type List[str]
items = [item.split() for item in items]
# 'items' now has type List[List[str]]
...
```
This configuration change is especially helpful in reducing the number
of `# type: ignore` directives needed to handle the common pattern of:
* Accepting a filepath as a string
* Overwriting the variable using `filepath = ensure_path(filepath)`
These changes enable redefinition and remove all `# type: ignore`
directives rendered redundant by this change.
* 🏷 Add type annotation to converters mapping
* 🚨 Fix Mypy error in convert CLI argument verification
* 🏷 Improve type annotation on `resolve_dot_names` helper
* 🏷 Add type annotations for `Vocab` attributes `strings` and `vectors`
* 🏷 Add type annotations for more `Vocab` attributes
* 🏷 Add loose type annotation for gold data compilation
* 🏷 Improve `_format_labels` type annotation
* 🏷 Fix `get_lang_class` type annotation
* 🏷 Loosen return type of `Language.evaluate`
* 🏷 Don't accept `Scorer` in `handle_scores_per_type`
* 🏷 Add `string_to_list` overloads
* 🏷 Fix non-Optional command-line options
* 🙈 Ignore redefinition of `wandb_logger` in `loggers.py`
* ➕ Install `typing_extensions` in Python 3.8+
The `typing_extensions` package states that it should be used when
"writing code that must be compatible with multiple Python versions".
Since SpaCy needs to support multiple Python versions, it should be used
when newer `typing` module members are required. One example of this is
`Literal`, which is available starting with Python 3.8.
Previously SpaCy tried to import `Literal` from `typing`, falling back
to `typing_extensions` if the import failed. However, Mypy doesn't seem
to be able to understand what `Literal` means when the initial import
means. Therefore, these changes modify how `compat` imports `Literal` by
always importing it from `typing_extensions`.
These changes also modify how `typing_extensions` is installed, so that
it is a requirement for all Python versions, including those greater
than or equal to 3.8.
* 🏷 Improve type annotation for `Language.pipe`
These changes add a missing overload variant to the type signature of
`Language.pipe`. Additionally, the type signature is enhanced to allow
type checkers to differentiate between the two overload variants based
on the `as_tuple` parameter.
Fixes #8772
* ➖ Don't install `typing-extensions` in Python 3.8+
After more detailed analysis of how to implement Python version-specific
type annotations using SpaCy, it has been determined that by branching
on a comparison against `sys.version_info` can be statically analyzed by
Mypy well enough to enable us to conditionally use
`typing_extensions.Literal`. This means that we no longer need to
install `typing_extensions` for Python versions greater than or equal to
3.8! 🎉
These changes revert previous changes installing `typing-extensions`
regardless of Python version and modify how we import the `Literal` type
to ensure that Mypy treats it properly.
* resolve mypy errors for Strict pydantic types
* refactor code to avoid missing return statement
* fix types of convert CLI command
* avoid list-set confustion in debug_data
* fix typo and formatting
* small fixes to avoid type ignores
* fix types in profile CLI command and make it more efficient
* type fixes in projects CLI
* put one ignore back
* type fixes for render
* fix render types - the sequel
* fix BaseDefault in language definitions
* fix type of noun_chunks iterator - yields tuple instead of span
* fix types in language-specific modules
* 🏷 Expand accepted inputs of `get_string_id`
`get_string_id` accepts either a string (in which case it returns its
ID) or an ID (in which case it immediately returns the ID). These
changes extend the type annotation of `get_string_id` to indicate that
it can accept either strings or IDs.
* 🏷 Handle override types in `combine_score_weights`
The `combine_score_weights` function allows users to pass an `overrides`
mapping to override data extracted from the `weights` argument. Since it
allows `Optional` dictionary values, the return value may also include
`Optional` dictionary values.
These changes update the type annotations for `combine_score_weights` to
reflect this fact.
* 🏷 Fix tokenizer serialization method signatures in `DummyTokenizer`
* 🏷 Fix redefinition of `wandb_logger`
These changes fix the redefinition of `wandb_logger` by giving a
separate name to each `WandbLogger` version. For
backwards-compatibility, `spacy.train` still exports `wandb_logger_v3`
as `wandb_logger` for now.
* more fixes for typing in language
* type fixes in model definitions
* 🏷 Annotate `_RandomWords.probs` as `NDArray`
* 🏷 Annotate `tok2vec` layers to help Mypy
* 🐛 Fix `_RandomWords.probs` type annotations for Python 3.6
Also remove an import that I forgot to move to the top of the module 😅
* more fixes for matchers and other pipeline components
* quick fix for entity linker
* fixing types for spancat, textcat, etc
* bugfix for tok2vec
* type annotations for scorer
* add runtime_checkable for Protocol
* type and import fixes in tests
* mypy fixes for training utilities
* few fixes in util
* fix import
* 🐵 Remove unused `# type: ignore` directives
* 🏷 Annotate `Language._components`
* 🏷 Annotate `spacy.pipeline.Pipe`
* add doc as property to span.pyi
* small fixes and cleanup
* explicit type annotations instead of via comment
Co-authored-by: Adriane Boyd <adrianeboyd@gmail.com>
Co-authored-by: svlandeg <sofie.vanlandeghem@gmail.com>
Co-authored-by: svlandeg <svlandeg@github.com>
2021-10-14 16:21:40 +03:00
|
|
|
from typing import Union, Iterable, Sequence, TypeVar, List, Callable, Iterator
|
2020-08-04 16:09:37 +03:00
|
|
|
from typing import Optional, Any
|
|
|
|
from functools import partial
|
|
|
|
import itertools
|
2023-01-18 20:28:30 +03:00
|
|
|
from thinc.schedules import Schedule
|
2020-08-04 16:09:37 +03:00
|
|
|
|
|
|
|
from ..util import registry, minibatch
|
|
|
|
|
|
|
|
|
2023-01-18 20:28:30 +03:00
|
|
|
SizingSchedule = Union[Iterable[int], int, Schedule]
|
|
|
|
Sizing = Union[Iterable[int], int]
|
2020-08-04 16:09:37 +03:00
|
|
|
ItemT = TypeVar("ItemT")
|
|
|
|
BatcherT = Callable[[Iterable[ItemT]], Iterable[List[ItemT]]]
|
|
|
|
|
|
|
|
|
2020-09-03 18:30:41 +03:00
|
|
|
@registry.batchers("spacy.batch_by_padded.v1")
|
2020-08-04 16:09:37 +03:00
|
|
|
def configure_minibatch_by_padded_size(
|
|
|
|
*,
|
2023-01-18 20:28:30 +03:00
|
|
|
size: SizingSchedule,
|
2020-08-04 16:09:37 +03:00
|
|
|
buffer: int,
|
|
|
|
discard_oversize: bool,
|
|
|
|
get_length: Optional[Callable[[ItemT], int]] = None
|
|
|
|
) -> BatcherT:
|
2020-08-07 19:51:02 +03:00
|
|
|
"""Create a batcher that uses the `batch_by_padded_size` strategy.
|
2020-08-09 23:36:23 +03:00
|
|
|
|
2020-08-07 19:51:02 +03:00
|
|
|
The padded size is defined as the maximum length of sequences within the
|
|
|
|
batch multiplied by the number of sequences in the batch.
|
|
|
|
|
2023-01-18 20:28:30 +03:00
|
|
|
size (int, Iterable[int] or Schedule): The largest padded size to batch sequences
|
|
|
|
into. Can be a single integer, or a sequence, allowing for variable batch sizes.
|
2020-08-07 19:51:02 +03:00
|
|
|
buffer (int): The number of sequences to accumulate before sorting by length.
|
|
|
|
A larger buffer will result in more even sizing, but if the buffer is
|
|
|
|
very large, the iteration order will be less random, which can result
|
|
|
|
in suboptimal training.
|
|
|
|
discard_oversize (bool): Whether to discard sequences that are by themselves
|
|
|
|
longer than the largest padded batch size.
|
|
|
|
get_length (Callable or None): Function to get the length of a sequence item.
|
|
|
|
The `len` function is used by default.
|
|
|
|
"""
|
2020-08-04 16:09:37 +03:00
|
|
|
# Avoid displacing optional values from the underlying function.
|
|
|
|
optionals = {"get_length": get_length} if get_length is not None else {}
|
|
|
|
return partial(
|
|
|
|
minibatch_by_padded_size,
|
2023-01-18 20:28:30 +03:00
|
|
|
size=_schedule_to_sizing(size),
|
2020-08-04 16:09:37 +03:00
|
|
|
buffer=buffer,
|
|
|
|
discard_oversize=discard_oversize,
|
|
|
|
**optionals
|
|
|
|
)
|
|
|
|
|
|
|
|
|
2020-09-03 18:30:41 +03:00
|
|
|
@registry.batchers("spacy.batch_by_words.v1")
|
2020-08-04 16:09:37 +03:00
|
|
|
def configure_minibatch_by_words(
|
|
|
|
*,
|
2023-01-18 20:28:30 +03:00
|
|
|
size: SizingSchedule,
|
2020-08-04 16:09:37 +03:00
|
|
|
tolerance: float,
|
|
|
|
discard_oversize: bool,
|
|
|
|
get_length: Optional[Callable[[ItemT], int]] = None
|
|
|
|
) -> BatcherT:
|
2020-08-07 19:51:02 +03:00
|
|
|
"""Create a batcher that uses the "minibatch by words" strategy.
|
|
|
|
|
2023-01-18 20:28:30 +03:00
|
|
|
size (int, Iterable[int] or Schedule): The target number of words per batch.
|
2020-08-07 19:51:02 +03:00
|
|
|
Can be a single integer, or a sequence, allowing for variable batch sizes.
|
|
|
|
tolerance (float): What percentage of the size to allow batches to exceed.
|
|
|
|
discard_oversize (bool): Whether to discard sequences that by themselves
|
|
|
|
exceed the tolerated size.
|
|
|
|
get_length (Callable or None): Function to get the length of a sequence
|
|
|
|
item. The `len` function is used by default.
|
|
|
|
"""
|
2020-08-04 16:09:37 +03:00
|
|
|
optionals = {"get_length": get_length} if get_length is not None else {}
|
|
|
|
return partial(
|
2021-06-28 12:48:00 +03:00
|
|
|
minibatch_by_words,
|
2023-01-18 20:28:30 +03:00
|
|
|
size=_schedule_to_sizing(size),
|
2021-06-28 12:48:00 +03:00
|
|
|
tolerance=tolerance,
|
|
|
|
discard_oversize=discard_oversize,
|
|
|
|
**optionals
|
2020-08-04 16:09:37 +03:00
|
|
|
)
|
|
|
|
|
|
|
|
|
2020-09-03 18:30:41 +03:00
|
|
|
@registry.batchers("spacy.batch_by_sequence.v1")
|
2020-08-05 21:29:46 +03:00
|
|
|
def configure_minibatch(
|
2023-01-18 20:28:30 +03:00
|
|
|
size: SizingSchedule, get_length: Optional[Callable[[ItemT], int]] = None
|
2020-08-05 21:29:46 +03:00
|
|
|
) -> BatcherT:
|
2020-08-07 19:51:02 +03:00
|
|
|
"""Create a batcher that creates batches of the specified size.
|
|
|
|
|
2023-01-18 20:28:30 +03:00
|
|
|
size (int, Iterable[int] or Schedule): The target number of items per batch.
|
2020-08-07 19:51:02 +03:00
|
|
|
Can be a single integer, or a sequence, allowing for variable batch sizes.
|
|
|
|
"""
|
2020-08-05 17:00:59 +03:00
|
|
|
optionals = {"get_length": get_length} if get_length is not None else {}
|
2023-01-18 20:28:30 +03:00
|
|
|
return partial(minibatch, size=_schedule_to_sizing(size), **optionals)
|
2020-08-04 16:09:37 +03:00
|
|
|
|
|
|
|
|
|
|
|
def minibatch_by_padded_size(
|
2020-08-07 19:51:02 +03:00
|
|
|
seqs: Iterable[ItemT],
|
2020-08-04 16:09:37 +03:00
|
|
|
size: Sizing,
|
|
|
|
buffer: int = 256,
|
|
|
|
discard_oversize: bool = False,
|
|
|
|
get_length: Callable = len,
|
2020-08-07 19:51:02 +03:00
|
|
|
) -> Iterable[List[ItemT]]:
|
|
|
|
"""Minibatch a sequence by the size of padded batches that would result,
|
|
|
|
with sequences binned by length within a window.
|
2020-08-09 23:36:23 +03:00
|
|
|
|
2020-08-07 19:51:02 +03:00
|
|
|
The padded size is defined as the maximum length of sequences within the
|
|
|
|
batch multiplied by the number of sequences in the batch.
|
|
|
|
|
2023-01-18 20:28:30 +03:00
|
|
|
size (int or Iterable[int]): The largest padded size to batch sequences into.
|
2020-08-07 19:51:02 +03:00
|
|
|
buffer (int): The number of sequences to accumulate before sorting by length.
|
|
|
|
A larger buffer will result in more even sizing, but if the buffer is
|
|
|
|
very large, the iteration order will be less random, which can result
|
|
|
|
in suboptimal training.
|
|
|
|
discard_oversize (bool): Whether to discard sequences that are by themselves
|
|
|
|
longer than the largest padded batch size.
|
|
|
|
get_length (Callable or None): Function to get the length of a sequence item.
|
|
|
|
The `len` function is used by default.
|
|
|
|
"""
|
2020-08-04 16:09:37 +03:00
|
|
|
if isinstance(size, int):
|
2023-01-18 20:28:30 +03:00
|
|
|
size_: Iterator[int] = itertools.repeat(size)
|
2020-08-04 16:09:37 +03:00
|
|
|
else:
|
2023-01-18 20:28:30 +03:00
|
|
|
size_ = iter(size)
|
|
|
|
for outer_batch in minibatch(seqs, size=buffer):
|
2020-08-04 16:09:37 +03:00
|
|
|
outer_batch = list(outer_batch)
|
2023-01-18 20:28:30 +03:00
|
|
|
target_size = next(size_)
|
2020-08-04 16:09:37 +03:00
|
|
|
for indices in _batch_by_length(outer_batch, target_size, get_length):
|
|
|
|
subbatch = [outer_batch[i] for i in indices]
|
|
|
|
padded_size = max(len(seq) for seq in subbatch) * len(subbatch)
|
|
|
|
if discard_oversize and padded_size >= target_size:
|
|
|
|
pass
|
|
|
|
else:
|
|
|
|
yield subbatch
|
|
|
|
|
|
|
|
|
|
|
|
def minibatch_by_words(
|
2020-08-09 23:36:23 +03:00
|
|
|
seqs: Iterable[ItemT],
|
|
|
|
size: Sizing,
|
|
|
|
tolerance=0.2,
|
|
|
|
discard_oversize=False,
|
|
|
|
get_length=len,
|
2020-08-07 19:51:02 +03:00
|
|
|
) -> Iterable[List[ItemT]]:
|
2020-08-04 16:09:37 +03:00
|
|
|
"""Create minibatches of roughly a given number of words. If any examples
|
|
|
|
are longer than the specified batch length, they will appear in a batch by
|
|
|
|
themselves, or be discarded if discard_oversize=True.
|
2020-08-07 19:51:02 +03:00
|
|
|
|
|
|
|
seqs (Iterable[Sequence]): The sequences to minibatch.
|
2023-01-18 20:28:30 +03:00
|
|
|
size (int or Iterable[int]): The target number of words per batch.
|
2020-08-07 19:51:02 +03:00
|
|
|
Can be a single integer, or a sequence, allowing for variable batch sizes.
|
|
|
|
tolerance (float): What percentage of the size to allow batches to exceed.
|
|
|
|
discard_oversize (bool): Whether to discard sequences that by themselves
|
|
|
|
exceed the tolerated size.
|
|
|
|
get_length (Callable or None): Function to get the length of a sequence
|
|
|
|
item. The `len` function is used by default.
|
2020-08-05 21:29:46 +03:00
|
|
|
"""
|
2020-08-04 16:09:37 +03:00
|
|
|
if isinstance(size, int):
|
2023-01-18 20:28:30 +03:00
|
|
|
size_: Iterator[int] = itertools.repeat(size)
|
2020-08-04 16:09:37 +03:00
|
|
|
else:
|
2023-01-18 20:28:30 +03:00
|
|
|
size_ = iter(size)
|
|
|
|
target_size = next(size_)
|
2020-08-04 16:09:37 +03:00
|
|
|
tol_size = target_size * tolerance
|
|
|
|
batch = []
|
|
|
|
overflow = []
|
|
|
|
batch_size = 0
|
|
|
|
overflow_size = 0
|
2020-08-07 19:51:02 +03:00
|
|
|
for seq in seqs:
|
|
|
|
n_words = get_length(seq)
|
2020-08-04 16:09:37 +03:00
|
|
|
# if the current example exceeds the maximum batch size, it is returned separately
|
|
|
|
# but only if discard_oversize=False.
|
|
|
|
if n_words > target_size + tol_size:
|
|
|
|
if not discard_oversize:
|
2020-08-07 19:51:02 +03:00
|
|
|
yield [seq]
|
2020-08-04 16:09:37 +03:00
|
|
|
# add the example to the current batch if there's no overflow yet and it still fits
|
|
|
|
elif overflow_size == 0 and (batch_size + n_words) <= target_size:
|
2020-08-07 19:51:02 +03:00
|
|
|
batch.append(seq)
|
2020-08-04 16:09:37 +03:00
|
|
|
batch_size += n_words
|
|
|
|
# add the example to the overflow buffer if it fits in the tolerance margin
|
|
|
|
elif (batch_size + overflow_size + n_words) <= (target_size + tol_size):
|
2020-08-07 19:51:02 +03:00
|
|
|
overflow.append(seq)
|
2020-08-04 16:09:37 +03:00
|
|
|
overflow_size += n_words
|
|
|
|
# yield the previous batch and start a new one. The new one gets the overflow examples.
|
|
|
|
else:
|
|
|
|
if batch:
|
|
|
|
yield batch
|
2023-01-18 20:28:30 +03:00
|
|
|
target_size = next(size_)
|
2020-08-04 16:09:37 +03:00
|
|
|
tol_size = target_size * tolerance
|
|
|
|
batch = overflow
|
|
|
|
batch_size = overflow_size
|
|
|
|
overflow = []
|
|
|
|
overflow_size = 0
|
|
|
|
# this example still fits
|
|
|
|
if (batch_size + n_words) <= target_size:
|
2020-08-07 19:51:02 +03:00
|
|
|
batch.append(seq)
|
2020-08-04 16:09:37 +03:00
|
|
|
batch_size += n_words
|
|
|
|
# this example fits in overflow
|
|
|
|
elif (batch_size + n_words) <= (target_size + tol_size):
|
2020-08-07 19:51:02 +03:00
|
|
|
overflow.append(seq)
|
2020-08-04 16:09:37 +03:00
|
|
|
overflow_size += n_words
|
|
|
|
# this example does not fit with the previous overflow: start another new batch
|
|
|
|
else:
|
|
|
|
if batch:
|
|
|
|
yield batch
|
2023-01-18 20:28:30 +03:00
|
|
|
target_size = next(size_)
|
2020-08-04 16:09:37 +03:00
|
|
|
tol_size = target_size * tolerance
|
2020-08-07 19:51:02 +03:00
|
|
|
batch = [seq]
|
2020-08-04 16:09:37 +03:00
|
|
|
batch_size = n_words
|
|
|
|
batch.extend(overflow)
|
|
|
|
if batch:
|
|
|
|
yield batch
|
|
|
|
|
|
|
|
|
|
|
|
def _batch_by_length(
|
|
|
|
seqs: Sequence[Any], max_words: int, get_length=len
|
|
|
|
) -> List[List[Any]]:
|
|
|
|
"""Given a list of sequences, return a batched list of indices into the
|
|
|
|
list, where the batches are grouped by length, in descending order.
|
|
|
|
|
|
|
|
Batches may be at most max_words in size, defined as max sequence length * size.
|
|
|
|
"""
|
|
|
|
# Use negative index so we can get sort by position ascending.
|
|
|
|
lengths_indices = [(get_length(seq), i) for i, seq in enumerate(seqs)]
|
|
|
|
lengths_indices.sort()
|
|
|
|
batches = []
|
🏷 Add Mypy check to CI and ignore all existing Mypy errors (#9167)
* 🚨 Ignore all existing Mypy errors
* 🏗 Add Mypy check to CI
* Add types-mock and types-requests as dev requirements
* Add additional type ignore directives
* Add types packages to dev-only list in reqs test
* Add types-dataclasses for python 3.6
* Add ignore to pretrain
* 🏷 Improve type annotation on `run_command` helper
The `run_command` helper previously declared that it returned an
`Optional[subprocess.CompletedProcess]`, but it isn't actually possible
for the function to return `None`. These changes modify the type
annotation of the `run_command` helper and remove all now-unnecessary
`# type: ignore` directives.
* 🔧 Allow variable type redefinition in limited contexts
These changes modify how Mypy is configured to allow variables to have
their type automatically redefined under certain conditions. The Mypy
documentation contains the following example:
```python
def process(items: List[str]) -> None:
# 'items' has type List[str]
items = [item.split() for item in items]
# 'items' now has type List[List[str]]
...
```
This configuration change is especially helpful in reducing the number
of `# type: ignore` directives needed to handle the common pattern of:
* Accepting a filepath as a string
* Overwriting the variable using `filepath = ensure_path(filepath)`
These changes enable redefinition and remove all `# type: ignore`
directives rendered redundant by this change.
* 🏷 Add type annotation to converters mapping
* 🚨 Fix Mypy error in convert CLI argument verification
* 🏷 Improve type annotation on `resolve_dot_names` helper
* 🏷 Add type annotations for `Vocab` attributes `strings` and `vectors`
* 🏷 Add type annotations for more `Vocab` attributes
* 🏷 Add loose type annotation for gold data compilation
* 🏷 Improve `_format_labels` type annotation
* 🏷 Fix `get_lang_class` type annotation
* 🏷 Loosen return type of `Language.evaluate`
* 🏷 Don't accept `Scorer` in `handle_scores_per_type`
* 🏷 Add `string_to_list` overloads
* 🏷 Fix non-Optional command-line options
* 🙈 Ignore redefinition of `wandb_logger` in `loggers.py`
* ➕ Install `typing_extensions` in Python 3.8+
The `typing_extensions` package states that it should be used when
"writing code that must be compatible with multiple Python versions".
Since SpaCy needs to support multiple Python versions, it should be used
when newer `typing` module members are required. One example of this is
`Literal`, which is available starting with Python 3.8.
Previously SpaCy tried to import `Literal` from `typing`, falling back
to `typing_extensions` if the import failed. However, Mypy doesn't seem
to be able to understand what `Literal` means when the initial import
means. Therefore, these changes modify how `compat` imports `Literal` by
always importing it from `typing_extensions`.
These changes also modify how `typing_extensions` is installed, so that
it is a requirement for all Python versions, including those greater
than or equal to 3.8.
* 🏷 Improve type annotation for `Language.pipe`
These changes add a missing overload variant to the type signature of
`Language.pipe`. Additionally, the type signature is enhanced to allow
type checkers to differentiate between the two overload variants based
on the `as_tuple` parameter.
Fixes #8772
* ➖ Don't install `typing-extensions` in Python 3.8+
After more detailed analysis of how to implement Python version-specific
type annotations using SpaCy, it has been determined that by branching
on a comparison against `sys.version_info` can be statically analyzed by
Mypy well enough to enable us to conditionally use
`typing_extensions.Literal`. This means that we no longer need to
install `typing_extensions` for Python versions greater than or equal to
3.8! 🎉
These changes revert previous changes installing `typing-extensions`
regardless of Python version and modify how we import the `Literal` type
to ensure that Mypy treats it properly.
* resolve mypy errors for Strict pydantic types
* refactor code to avoid missing return statement
* fix types of convert CLI command
* avoid list-set confustion in debug_data
* fix typo and formatting
* small fixes to avoid type ignores
* fix types in profile CLI command and make it more efficient
* type fixes in projects CLI
* put one ignore back
* type fixes for render
* fix render types - the sequel
* fix BaseDefault in language definitions
* fix type of noun_chunks iterator - yields tuple instead of span
* fix types in language-specific modules
* 🏷 Expand accepted inputs of `get_string_id`
`get_string_id` accepts either a string (in which case it returns its
ID) or an ID (in which case it immediately returns the ID). These
changes extend the type annotation of `get_string_id` to indicate that
it can accept either strings or IDs.
* 🏷 Handle override types in `combine_score_weights`
The `combine_score_weights` function allows users to pass an `overrides`
mapping to override data extracted from the `weights` argument. Since it
allows `Optional` dictionary values, the return value may also include
`Optional` dictionary values.
These changes update the type annotations for `combine_score_weights` to
reflect this fact.
* 🏷 Fix tokenizer serialization method signatures in `DummyTokenizer`
* 🏷 Fix redefinition of `wandb_logger`
These changes fix the redefinition of `wandb_logger` by giving a
separate name to each `WandbLogger` version. For
backwards-compatibility, `spacy.train` still exports `wandb_logger_v3`
as `wandb_logger` for now.
* more fixes for typing in language
* type fixes in model definitions
* 🏷 Annotate `_RandomWords.probs` as `NDArray`
* 🏷 Annotate `tok2vec` layers to help Mypy
* 🐛 Fix `_RandomWords.probs` type annotations for Python 3.6
Also remove an import that I forgot to move to the top of the module 😅
* more fixes for matchers and other pipeline components
* quick fix for entity linker
* fixing types for spancat, textcat, etc
* bugfix for tok2vec
* type annotations for scorer
* add runtime_checkable for Protocol
* type and import fixes in tests
* mypy fixes for training utilities
* few fixes in util
* fix import
* 🐵 Remove unused `# type: ignore` directives
* 🏷 Annotate `Language._components`
* 🏷 Annotate `spacy.pipeline.Pipe`
* add doc as property to span.pyi
* small fixes and cleanup
* explicit type annotations instead of via comment
Co-authored-by: Adriane Boyd <adrianeboyd@gmail.com>
Co-authored-by: svlandeg <sofie.vanlandeghem@gmail.com>
Co-authored-by: svlandeg <svlandeg@github.com>
2021-10-14 16:21:40 +03:00
|
|
|
batch: List[int] = []
|
2020-08-04 16:09:37 +03:00
|
|
|
for length, i in lengths_indices:
|
|
|
|
if not batch:
|
|
|
|
batch.append(i)
|
|
|
|
elif length * (len(batch) + 1) <= max_words:
|
|
|
|
batch.append(i)
|
|
|
|
else:
|
|
|
|
batches.append(batch)
|
|
|
|
batch = [i]
|
|
|
|
if batch:
|
|
|
|
batches.append(batch)
|
|
|
|
# Check lengths match
|
|
|
|
assert sum(len(b) for b in batches) == len(seqs)
|
|
|
|
batches = [list(sorted(batch)) for batch in batches]
|
|
|
|
batches.reverse()
|
|
|
|
return batches
|
2023-01-18 20:28:30 +03:00
|
|
|
|
|
|
|
|
|
|
|
def _schedule_to_sizing(size: SizingSchedule) -> Sizing:
|
|
|
|
if isinstance(size, Schedule):
|
|
|
|
return size.to_generator()
|
|
|
|
return size
|