mirror of
https://github.com/explosion/spaCy.git
synced 2025-07-18 20:22:25 +03:00
Remove unused param, add TODOs about typing
This commit is contained in:
parent
6a8625e711
commit
13481fbcc2
|
@ -22,9 +22,8 @@ def build_wl_coref_model(
|
||||||
rough_k: int = 50,
|
rough_k: int = 50,
|
||||||
# TODO is this not a training loop setting?
|
# TODO is this not a training loop setting?
|
||||||
a_scoring_batch_size: int = 512,
|
a_scoring_batch_size: int = 512,
|
||||||
# span predictor embeddings
|
|
||||||
sp_embedding_size: int = 64,
|
|
||||||
):
|
):
|
||||||
|
# TODO add model return types
|
||||||
# TODO fix this
|
# TODO fix this
|
||||||
try:
|
try:
|
||||||
dim = tok2vec.get_dim("nO")
|
dim = tok2vec.get_dim("nO")
|
||||||
|
|
|
@ -17,6 +17,7 @@ def build_span_predictor(
|
||||||
hidden_size: int = 1024,
|
hidden_size: int = 1024,
|
||||||
dist_emb_size: int = 64,
|
dist_emb_size: int = 64,
|
||||||
):
|
):
|
||||||
|
# TODO add model return types
|
||||||
# TODO fix this
|
# TODO fix this
|
||||||
try:
|
try:
|
||||||
dim = tok2vec.get_dim("nO")
|
dim = tok2vec.get_dim("nO")
|
||||||
|
|
Loading…
Reference in New Issue
Block a user