explosion/spaCy
1
1
Fork 0
mirror of https://github.com/explosion/spaCy.git synced 2025-07-10 08:12:24 +03:00
Code Issues Packages Projects Releases Wiki Activity

Update setup.py. Remove temporary comments.

Browse Source
This commit is contained in:
Raphael Mitsch 2022-11-29 15:15:47 +01:00
parent 3e668503de
commit 60eda0d7a5
3 changed files with 0 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
setup.py
View File

@ -30,7 +30,6 @@ MOD_NAMES = [
"spacy.lexeme", "spacy.lexeme",
"spacy.vocab", "spacy.vocab",
"spacy.attrs", "spacy.attrs",
"spacy.kb.candidate",
"spacy.kb.kb", "spacy.kb.kb",
"spacy.kb.kb_in_memory", "spacy.kb.kb_in_memory",
"spacy.ml.parser_model", "spacy.ml.parser_model",

5
spacy/kb/candidate.py
View File

@ -47,11 +47,6 @@ class BaseCandidate(abc.ABC):
class Candidate(BaseCandidate): class Candidate(BaseCandidate):
"""`Candidate` for InMemoryLookupKBCandidate.""" """`Candidate` for InMemoryLookupKBCandidate."""
# todo
# - glue together
# - is candidate definition necessary for EL? as long as interface fulfills requirements, this shouldn't matter.
# otherwise incorporate new argument.
# - fix test failures (100% backwards-compatible should be possible after changing EntityLinker)
def __init__( def __init__(
self, self,
retrieve_string_from_hash: Callable[[int], str], retrieve_string_from_hash: Callable[[int], str],

2
spacy/tests/pipeline/test_entity_linker.py
View File

@ -496,8 +496,6 @@ def test_el_pipe_configuration(nlp):
doc = nlp(text) doc = nlp(text)
assert doc[0].ent_kb_id_ == "NIL" assert doc[0].ent_kb_id_ == "NIL"
assert doc[1].ent_kb_id_ == "" assert doc[1].ent_kb_id_ == ""
# todo It's unclear why EL doesn't learn properly for this test anymore (scores are 0). Seemed to work before, but
# no relevant changes in EL code were made since these tests were added AFAIK (CG seems to work fine).
assert doc[2].ent_kb_id_ in ("Q2", "Q3") assert doc[2].ent_kb_id_ in ("Q2", "Q3")
# Replace the pipe with a new one with with a different candidate generator. # Replace the pipe with a new one with with a different candidate generator.