spaCy/spacy/pipeline
Paul O'Leary McCann 6920fb7baf
Move Entity Linker v1 to spacy-legacy (#12006)
* Move Entity Linker v1 component to spacy-legacy

This is a follow up to #11889 that moves the component instead of
removing it.

In general, we never import from spacy-legacy in spaCy proper. However,
to use this component, that kind of import will be necessary. I was able
to test this without issues, but is this current import strategy
acceptable? Or should we put the component in a registry?

* Use spacy-legacy pr for CI

This will need to be reverted before merging.

* Add temporary step to log installed spacy-legacy version

* Modify requirements.txt to trigger tests

* Add comment to Python to trigger tests

* TODO REVERT This is a commit with logic changes to trigger tests

* Remove pipe from YAML

Works locally, but possibly this is causing a quoting error or
something.

* Revert "TODO REVERT This is a commit with logic changes to trigger tests"

This reverts commit 689fae71f3.

* Revert "Add comment to Python to trigger tests"

This reverts commit 11840fc598.

* Add more logging

* Try installing directly in workflow

* Try explicitly uninstalling spacy-legacy first

* Cat requirements.txt to confirm contents

In the branch, the thinc version spec is `thinc>=8.1.0,<8.2.0`. But in
the logs, it's clear that a development release of 9.0 is being
installed. It's not clear why that would happen.

* Log requirements at start of build

* TODO REVERT Change thinc spec

Want to see what happens to the installed thinc spec with this change.

* Update thinc requirements

This makes it the same as it was before the merge, >=8.1.0,<8.2.0.

* Use same thinc version as v4 branch

* TODO REVERT Mark dependency check as xfail

spacy-legacy is specified as a git checkout in requirements.txt while
this PR is in progress, which makes the consistency check here fail.

* Remove debugging output / install step

* Revert "Remove debugging output / install step"

This reverts commit 923ea7448b.

* Clean up debugging output

The manual install step with the URL fragment seems to have caused
issues on Windows due to the = in the URL being misinterpreted. On the
other hand, removing it seems to mean the git version of spacy-legacy
isn't actually installed.

This PR removes the URL fragment but keeps the direct command-line
install. Additionally, since it looks like this job is configured to use
the default shell (and not bash), it removes a comment that upsets the
Windows cmd shell.

* Revert "TODO REVERT Mark dependency check as xfail"

This reverts commit d4863ec156.

* Fix requirements.txt, increasing spacy-legacy version

* Raise spacy legacy version in setup.cfg

* Remove azure build workarounds

* make spacy-legacy version explicit in error message

* Remove debugging line

* Suggestions from code review
2023-02-01 09:47:56 +01:00
..
_edit_tree_internals Refactor error messages to remove hardcoded strings (#10729) 2022-05-02 13:38:46 +02:00
_parser_internals Merge the parser refactor into v4 (#10940) 2023-01-18 11:27:45 +01:00
__init__.py Replace EntityRuler with SpanRuler implementation (#11320) 2022-10-24 09:11:35 +02:00
attribute_ruler.py Make stable private modules public and adjust names (#11353) 2022-08-30 13:56:35 +02:00
dep_parser.py Merge the parser refactor into v4 (#10940) 2023-01-18 11:27:45 +01:00
edit_tree_lemmatizer.py Format 2023-01-27 08:29:46 +01:00
entity_linker.py Move Entity Linker v1 to spacy-legacy (#12006) 2023-02-01 09:47:56 +01:00
entityruler.py Merge branch 'copy_master' into copy_v4 2023-01-11 18:40:55 +01:00
functions.py Add doc_cleaner component (#9659) 2021-11-23 15:33:33 +01:00
lemmatizer.py Merge remote-tracking branch 'upstream/master' into chore/update-develop-from-master-v3.2-1 2021-10-26 11:53:50 +02:00
morphologizer.pyx Fix v4 branch to build against Thinc v9 (#11921) 2022-12-17 14:32:19 +01:00
ner.py Format 2023-01-27 08:29:46 +01:00
pipe.pxd TrainablePipe (#6213) 2020-10-08 21:33:49 +02:00
pipe.pyi Add Pipe.hide_labels to omit labels from pipeline meta (#10175) 2022-02-05 17:59:24 +01:00
pipe.pyx Add TrainablePipe.{distill,get_teacher_student_loss} (#12016) 2023-01-16 10:25:53 +01:00
sentencizer.pyx Add overwrite settings for more components (#9050) 2021-09-30 15:35:55 +02:00
senter.pyx Fix v4 branch to build against Thinc v9 (#11921) 2022-12-17 14:32:19 +01:00
span_ruler.py Merge branch 'copy_master' into copy_v4 2023-01-11 18:40:55 +01:00
spancat.py Drop python 3.6/3.7, remove unneeded compat (#12187) 2023-01-27 15:48:20 +01:00
tagger.pyx Add TrainablePipe.{distill,get_teacher_student_loss} (#12016) 2023-01-16 10:25:53 +01:00
textcat_multilabel.py Merge branch 'copy_master' into copy_v4 2023-01-11 18:40:55 +01:00
textcat.py Merge branch 'copy_master' into copy_v4 2023-01-03 13:34:05 +01:00
tok2vec.py Prevent tok2vec to broadcast to listeners when predicting (#11385) 2022-09-12 15:36:48 +02:00
trainable_pipe.pxd Store activations in Docs when save_activations is enabled (#11002) 2022-09-13 09:51:12 +02:00
trainable_pipe.pyx Add Language.distill (#12116) 2023-01-30 12:44:11 +01:00
transition_parser.pyx Add Language.distill (#12116) 2023-01-30 12:44:11 +01:00