Andrew Murray
4038a287ee
Corrected pathlib.Path detection when saving
2021-07-24 14:21:33 +10:00
Hugo van Kemenade
50302231ed
Merge pull request #5552 from radarhere/palette
2021-06-28 19:01:54 +03:00
Andrew Murray
6db0e96102
Ensure image is loaded in remap_palette
2021-06-28 20:12:22 +10:00
Andrew Murray
4d36feefc7
Set palette to be empty by default
2021-06-23 19:22:21 +10:00
Andrew Murray
622ba122ce
Added Exif load_from_fp method to get TIFF tag_v2 data
2021-04-29 21:21:55 +10:00
Eric Soroos
1c872a9eda
lint stuff
2021-04-10 16:58:01 +02:00
Eric Soroos
a3a69c8385
conditional mark for valgrind ignore
2021-04-09 23:53:24 +02:00
wiredfool
9a683db339
Merge pull request #5274 from radarhere/gradient
...
Fixed linear_gradient and radial_gradient I and F modes
2021-03-28 14:35:22 +01:00
Andrew Murray
71cd97a519
Added deprecation warnings
2021-03-28 15:51:28 +11:00
Andrew Murray
68719fe6ea
Merge branch 'master' into exif
2021-03-15 12:41:45 +11:00
Andrew Murray
690cf9ebe2
Allow alpha_composite destination to be negative
2021-03-06 20:54:21 +11:00
Andrew Murray
297789284b
Fixed linear_gradient and radial_gradient 32-bit modes
2021-02-22 19:32:52 +11:00
Andrew Murray
e763f8f2be
Save interop IFD when converting Exif to bytes
2021-02-22 07:47:59 +11:00
Andrew Murray
4b14f0102d
Save base IFDs when converting Exif to bytes
2021-02-22 07:47:05 +11:00
Andrew Murray
faf8fad76d
Stopped flattening EXIF IFD into getexif()
2021-02-22 07:47:05 +11:00
Andrew Murray
3495b319bd
Replaced various instances of assert_image_similar with assert_image_similar_tofile
2021-02-21 22:22:29 +11:00
Andrew Murray
a5c251029c
Replaced various instances of assert_image_equal with assert_image_equal_tofile
2021-02-21 22:15:56 +11:00
Hugo van Kemenade
1857bf5570
Merge pull request #5259 from radarhere/warns
2021-02-17 21:31:15 +02:00
Andrew Murray
83542c42bf
Added context managers
2021-02-11 21:43:54 +11:00
Andrew Murray
4a0569e97f
Changed zero length assertions to falsy
2021-02-11 13:48:31 +11:00
Andrew Murray
01be700081
Fixed asserting that no warnings were raised
2021-02-10 23:37:55 +11:00
Piolie
4a9a999dbb
Update Tests/test_image.py
...
Keep the original test cases; add the most likely non-uppercase versions.
Co-authored-by: Andrew Murray <3112309+radarhere@users.noreply.github.com>
2021-02-05 12:21:27 -03:00
Piolie
0c1675a143
Make formats parameter in Image.open accept aNy cAsE
2021-02-04 22:47:53 -03:00
Eric Soroos
1d7c8e03d0
known failing tests from valgrind -- uninitialized values
2021-01-07 14:52:02 +01:00
Andrew Murray
903c67353d
Lint fix
2021-01-02 20:41:17 +11:00
Eric Soroos
2f409261eb
Fix for CVE CVE-2020-35655 - Read Overflow in PCX Decoding.
...
* Don't trust the image to specify a buffer size
2021-01-02 20:38:46 +11:00
Hugo van Kemenade
309cb9e5c4
Merge pull request #4927 from radarhere/tuple
2020-10-12 14:40:22 +03:00
Andrew Murray
7a1f0f6a8f
Fixed bug in Exif __delitem__
2020-10-05 09:45:05 +11:00
Andrew Murray
27c0747518
Allow tuples with one item to give single color value in getink
2020-09-20 14:23:05 +10:00
Andrew Murray
c83ffc6aea
Fixed effect_spread bug for zero distance
2020-09-08 18:51:58 +10:00
nulano
a340dc5fd3
Merge remote-tracking branch 'upstream/master' into formats
2020-09-04 21:07:34 +02:00
Andrew Murray
298b7d0333
Update pre-commit
2020-08-31 18:50:15 +10:00
Hugo van Kemenade
dd87dd50c0
Update to isort 5 with Black profile support
2020-08-08 22:39:29 +03:00
nulano
2b061b68db
add formats parameter to Image.open to restrict list of formats attempting to read an image file
2020-08-03 00:24:02 +02:00
Hugo van Kemenade
40aefc6ba5
Remove im.offset, deprecated in 2001; and fromstring and tostring, deprecated in 2013
2020-07-17 10:55:20 +03:00
Andrew Murray
9432bba6d1
Moved tests
2020-07-02 20:28:00 +10:00
Andrew Murray
ee06255ff0
Deprecated _showxv
2020-06-23 22:20:58 +10:00
nulano
66954ad176
deprecate Image.show(command="...")
2020-05-25 18:57:02 +02:00
Hugo
dda6145fce
Since Python 3.3 IOError and WindowsError have been merged into OSError
2020-04-10 12:57:29 +03:00
Hugo
ada137eba5
Fix Flake8
2020-04-01 10:52:21 +03:00
Eric Soroos
124f4bb591
Tests for PCX OOB Access
2020-04-01 10:50:48 +03:00
Andrew Murray
750bbc7256
Parametrized test
2020-03-31 17:41:52 +11:00
Andrew Murray
7597a9fbfd
Raise warning for more operations
2020-03-31 17:41:47 +11:00
Andrew Murray
027d180eda
Raise a DeprecationWarning when comparing PILLOW_VERSION
2020-03-30 21:53:02 +11:00
Hugo
44e661f25a
Convert to use pytest
2020-02-22 23:03:01 +02:00
Andrew Murray
8482919a37
Converted most assert statements to pytest
2020-02-23 00:06:21 +11:00
Jon Dufresne
98a2081a78
Move safe imports to the top of test files
...
These modules are safe to import and this better follows PEP 8.
From https://www.python.org/dev/peps/pep-0008/#imports
> Imports are always put at the top of the file, just after any module
> comments and docstrings, and before module globals and constants.
2020-02-17 10:49:27 -08:00
Hugo
38bf862185
Replace PillowTestCase.assert_warning with pytest.warns
2020-02-03 11:11:32 +02:00
Hugo
a4bf9fa036
Convert most PillowTestCase methods to pytest
2020-02-02 12:26:01 +02:00
Andrew Murray
be44f0d992
Catch SGI buffer overruns
2020-01-02 15:24:36 +11:00
Andrew Murray
8f0c8f7311
Catch PCX P mode buffer overrun
2020-01-02 15:24:16 +11:00
Andrew Murray
c40bc25847
Catch FLI buffer overrun
2020-01-02 15:23:36 +11:00
Andrew Murray
fedb0407b4
Raise ValueError for io.StringIO in Image.open
2019-12-26 18:53:06 +11:00
Andrew Murray
c0048ad7de
Use context managers
2019-11-26 07:03:23 +11:00
Jon Dufresne
33dabf986f
Import unittest from stdlib rather than helper.py
...
The unittest in helper.py has not offered an interesting abstraction
since dbe9f85c7d
2019-11-20 18:42:52 -08:00
Hugo van Kemenade
a949d7882e
Merge branch 'master' into rm-2.7
2019-11-20 10:26:55 +02:00
Andrew Murray
40f891dfd7
Added UnidentifiedImageError
2019-11-19 21:20:02 +11:00
Hugo
cc63f66575
Merge remote-tracking branch 'upstream/master' into rm-2.7
2019-11-01 13:22:56 +02:00
Jon Dufresne
4cd4adddc3
Improve handling of file resources
...
Follow Python's file object semantics. User code is responsible for
closing resources (usually through a context manager) in a deterministic
way.
To achieve this, remove __del__ functions. These functions used to
closed open file handlers in an attempt to silence Python
ResourceWarnings. However, using __del__ has the following drawbacks:
- __del__ isn't called until the object's reference count reaches 0.
Therefore, resource handlers remain open or in use longer than
necessary.
- The __del__ method isn't guaranteed to execute on system exit. See the
Python documentation:
https://docs.python.org/3/reference/datamodel.html#object.__del__
> It is not guaranteed that __del__() methods are called for objects
> that still exist when the interpreter exits.
- Exceptions that occur inside __del__ are ignored instead of raised.
This has the potential of hiding bugs. This is also in the Python
documentation:
> Warning: Due to the precarious circumstances under which __del__()
> methods are invoked, exceptions that occur during their execution
> are ignored, and a warning is printed to sys.stderr instead.
Instead, always close resource handlers when they are no longer in use.
This will close the file handler at a specified point in the user's code
and not wait until the interpreter chooses to. It is always guaranteed
to run. And, if an exception occurs while closing the file handler, the
bug will not be ignored.
Now, when code receives a ResourceWarning, it will highlight an area
that is mishandling resources. It should not simply be silenced, but
fixed by closing resources with a context manager.
All warnings that were emitted during tests have been cleaned up. To
enable warnings, I passed the `-Wa` CLI option to Python. This exposed
some mishandling of resources in ImageFile.__init__() and
SpiderImagePlugin.loadImageSeries(), they too were fixed.
2019-10-12 08:27:17 -07:00
Andrew Murray
4140cd807b
Merge branch 'master' into rm-2.7
2019-10-12 18:03:58 +11:00
nulano
a0a5601689
Merge branch 'master' into gha-win
2019-10-08 12:56:43 +01:00
Andrew Murray
6cd99fc3cf
Merge branch 'master' into rm-2.7
2019-10-08 18:57:27 +11:00
Jon Dufresne
64032061c0
Move several imports to the top-level of the file
...
This better follows PEP 8 style guide:
https://www.python.org/dev/peps/pep-0008/#imports
> Imports are always put at the top of the file, just after any module
> comments and docstrings, and before module globals and constants.
This also avoids duplicate import code within the same file.
2019-10-07 06:28:36 -07:00
Hugo
538d9e2e5d
Upgrade Python syntax with pyupgrade --py3-plus
2019-10-07 14:30:59 +03:00
Hugo
af770a6c55
Drop support for EOL Python 2.7
2019-10-07 14:30:59 +03:00
Andrew Murray
ab52630d06
Catch buffer overruns
2019-09-30 18:45:43 +10:00
nulano
cf1f8b0498
Tests.helper cleanup
2019-09-25 11:58:02 +02:00
Jon Dufresne
d50445ff30
Introduce isort to automate import ordering and formatting
...
Similar to the recent adoption of Black. isort is a Python utility to
sort imports alphabetically and automatically separate into sections. By
using isort, contributors can quickly and automatically conform to the
projects style without thinking. Just let the tool do it.
Uses the configuration recommended by the Black to avoid conflicts of
style.
Rewrite TestImageQt.test_deprecated to no rely on import order.
2019-07-06 16:11:35 -07:00
Hugo
77f946d8bc
Format with Black
2019-06-13 18:54:24 +03:00
Andrew Murray
691df96734
Fixed opening mmap image through Path on Windows
2019-05-04 15:00:49 +10:00
Hugo
a93bcdfe0c
Merge pull request #3724 from radarhere/readonly_save
...
Ensure image is mutable before saving
2019-03-28 11:53:33 +02:00
Hugo
adbe97594e
Merge pull request #3719 from radarhere/p_rgb_rgba
...
Allow RGB and RGBA values for new P images
2019-03-27 18:03:23 +02:00
Andrew Murray
0b62337b6f
Ensure image is mutable before saving
2019-03-17 23:37:40 +11:00
Andrew Murray
6790c2e375
Allow RGB and RGBA values for new P images
2019-03-15 17:35:05 +11:00
Andrew Murray
22b0110f89
Only close original fp in __del__ and __exit__ if original fp is exclusive
2019-03-12 08:54:43 +11:00
Jon Dufresne
4de5477b61
Remove unnecessary unittest.main() boilerplate from test files
...
With the introduction and use of pytest, it is simple and easy to
execute specific tests in isolation through documented command line
arguments. Either by specifying the module path or through the `-k
EXPRESSION` argument. There is no longer any need to provide the
boilerplate:
if __name__ == '__main__':
unittest.main()
To every test file. It is simply noise.
The pattern remains in test files that aren't named with `test_*` as
those files are not discovered and executed by pytest by default.
2019-02-03 10:10:16 -08:00
Jon Dufresne
7da17ad41e
Improve pytest configuration to allow specific tests as CLI args
...
The previous test configuration made it difficult to run a single test
with the pytest CLI. There were two major issues:
- The Tests directory was not a package. It now includes a __init__.py
file and imports from other tests modules are done with relative
imports.
- setup.cfg always specified the Tests directory. So even if a specific
test were specified as a CLI arg, this configuration would also always
include all tests. This configuration has been removed to allow
specifying a single test on the command line.
Contributors can now run specific tests with a single command such as:
$ tox -e py37 -- Tests/test_file_pdf.py::TestFilePdf.test_rgb
This makes it easy and faster to iterate on a single test failure and is
very familiar to those that have previously used tox and pytest.
When running tox or pytest with no arguments, they still discover and
runs all tests in the Tests directory.
2019-01-13 09:00:12 -08:00
Hugo
8a6f2b9de8
flake8: E711 comparison to None should be 'if cond is None:'
2018-11-11 19:01:10 +02:00
Hugo
d69ef6a529
Remove redundant parentheses
2018-10-24 22:29:56 +03:00
Hugo
a3b0659790
flake8
2018-10-24 22:29:01 +03:00
Hugo
d1ca4916e0
Use more specific assertions
2018-10-24 22:29:01 +03:00
Andrew Murray
0adeb82e98
Changed Image size property to be read-only by default
2018-09-30 13:45:18 +10:00
Andrew Murray
b4e6cdadac
Added py3 variable to _util
2018-04-20 09:19:13 +10:00
Andrew Murray
b560f5b417
Changed Python version checks in tests to use helper
2018-04-19 19:40:56 +10:00
Kathryn Davies
8f6be2ee7d
Move location of fclose and add dump test.
2018-03-31 21:28:37 -07:00
Hugo
8adab0ec0d
Noise effect: take five pixels, assert not all same
2017-12-19 17:12:58 +02:00
Hugo
11a2026f12
flake8
2017-12-19 15:12:02 +02:00
Hugo
c8eebc1dc7
Re-roll in case of identical noise
2017-12-19 15:06:43 +02:00
Jon Dufresne
c5a0d72c10
Remove unnecessary bool() calls throughout project
...
Can use truthy values in boolean expressions without first coercing to a
bool. Removes unnecessary call to bool().
2017-12-16 09:34:12 -08:00
Andrew Murray
28119dd68d
Changed test to use tempfile
2017-11-08 12:59:05 +11:00
wiredfool
c82f9fe1bb
Merge pull request #2738 from uploadcare/block-storage
...
Block & array hybrid storage
2017-10-01 20:41:08 +01:00
hugovk
9344bd20dd
Move test_no_resource_warning_for_numpy_array to test_numpy so it can be skipped easily
2017-09-23 22:39:10 +03:00
hugovk
0b6691ecc9
A numpy failing test for ResourceWarning on Python 3
2017-09-23 22:36:53 +03:00
hugovk
77f0608c4e
Failing test for ResourceWarning on Python 3
2017-09-23 22:36:03 +03:00
wiredfool
b8d6fd57fa
Merge pull request #1860 from radarhere/register_extensions
...
Added register_extensions method
2017-09-22 15:59:04 +01:00
Alexander
a78e92356f
Merge branch 'master' into block-storage
2017-09-19 21:08:21 +03:00
wiredfool
c786213b09
Merge pull request #2291 from asergi/pathlib2
...
Use pathlib2 for Path objects on Python < 3.4
2017-09-19 11:11:35 +01:00
Alexander
0054743100
fix zero size images
2017-09-17 02:58:01 +03:00
Andrew Murray
55d0a816c7
Added test
2017-09-04 20:32:15 +10:00
wiredfool
2611b2caa5
Merge pull request #2689 from radarhere/tests
...
Added tests
2017-09-04 11:15:28 +01:00
Andrew Murray
2ac18689d5
Removed unnecessary return statements
2017-09-01 21:06:22 +10:00
Andrew Murray
9e843a2d9b
Changed format of lambda calls
2017-09-01 21:05:40 +10:00
Andrew Murray
371933a597
Added tests
2017-09-01 20:36:51 +10:00
wiredfool
e422f92e52
Remove palettes from non-palette modes in _new #2702
2017-08-31 06:18:59 -07:00
wiredfool
e2602452f4
Merge pull request #2661 from uploadcare/get-channel
...
New Image.getchannel method
2017-08-16 15:33:54 +01:00
Alexander
e16ab0ad2e
add tests, fix implementation
2017-08-12 14:10:39 +03:00
Alexander
0649da02c6
fix tests on python 3
2017-08-06 14:12:55 +03:00
Alexander
6b50ba07fd
add tests for Image.new modes
2017-08-06 14:12:55 +03:00
wiredfool
c7efd0bf6d
re-organized the parameters, moved size specification to overlay tuple
2017-06-27 22:03:44 +01:00
wiredfool
1d33dfbced
Added source point parameter for Image.Image.alpha_composite
2017-06-27 22:03:44 +01:00
wiredfool
69768c514b
Added inplace alpha composite
2017-06-27 22:03:44 +01:00
Andrew Murray
e8cba27bb1
Changed assert checks to more specific versions
2017-06-03 14:04:54 +10:00
Andrew Murray
2a5447691a
Replaced deprecated assert_
2017-05-30 19:55:35 +10:00
Andrew Murray
37b293f593
Flake8 fixes
2017-04-20 21:14:23 +10:00
wiredfool
184d4f8dc0
Test encode registry
2017-03-11 21:27:07 +00:00
ces42
8fb44a2bee
More explicit error message when saving to a file with invalid extension ( #2399 )
...
* more explicit error message when saving to a file with invalid extension + test
2017-02-17 13:39:16 +00:00
Hugo
53e5702557
Update http to https
2017-02-14 11:27:02 +02:00
wiredfool
9c4eafc188
Merge pull request #2382 from hugovk/test-effects
...
Test linear and radial gradient effects
2017-02-06 21:58:41 +00:00
hugovk
d7fe8d1eb7
Linear and radial gradient: only need one target image
2017-02-06 22:03:17 +02:00
wiredfool
b93025fa5b
Merge pull request #2380 from evalapply/master
...
BUG fix: '' in image mode no longer causes a crash
2017-01-31 19:03:29 +00:00
hugovk
07af06bf8c
Expose and test radial_gradient
2017-01-29 18:44:24 +02:00
hugovk
3ead178d18
flake8
2017-01-29 18:38:06 +02:00
hugovk
47b1c66961
Expose and test linear_gradient
2017-01-29 18:17:31 +02:00
Lukasz Kozuchowski
3e317f3ca0
Empty image mode test
2017-01-29 07:50:28 +01:00
Andrew Murray
cd114cef3f
Added test for Image fromstring NotImplementedError
2017-01-28 14:16:39 +11:00
Andrew Murray
581fef2ebd
Added test for Image offset NotImplementedError
2017-01-28 13:06:28 +11:00
wiredfool
c1b510c72c
Merge pull request #2307 from radarhere/contextmanagers
...
Added context managers
2017-01-17 13:20:41 +00:00
Andrew Murray
89742225bf
Fixed test coverage
2017-01-07 13:20:16 +11:00
Andrew Murray
2a93cdb698
Simplified assertEqual checks to assertTrue
2017-01-07 11:35:09 +11:00
Luis G
dad5971561
Add unit tests
...
Add unit tests for registered_extensions
2017-01-07 11:32:16 +11:00
wiredfool
69bea50810
Allow 0 size images, Fixes #2259
2016-12-31 13:19:29 +00:00
Andrew Murray
a06dd59df7
Added context managers
2016-12-28 09:54:10 +11:00
Alessio Sergi
7e8a6c61f8
Use pathlib2 for Path objects on Python < 3.4
...
The pathlib backport module is no longer maintained. The development
has moved to the pathlib2 module instead.
Quoting from the pathlib's README:
"Attention: this backport module isn't maintained anymore. If you want
to report issues or contribute patches, please consider the pathlib2
project instead."
Other projects have already switched to pathlib2, most notably IPython
and its dependencies.
2016-12-17 18:50:50 +01:00
Andrew Murray
38fd77ca7d
Fixed bug in saving to fp-objects in Python >= 3.4
2016-11-15 20:13:25 +11:00
Andrew Murray
3dcef86fe5
Added missing top-level test code
2016-11-14 21:12:25 +11:00
Jon Dufresne
e44bb42ae9
Replace type() equality checks with isinstance
2016-10-31 06:41:43 -07:00
homm
923f0bb9b3
improve test
2016-10-04 03:11:53 +03:00
homm
c5e111e6b8
allow lists as arguments for Image.new
2016-10-04 03:06:35 +03:00
wiredfool
b3ad80a2bd
Image.core.open_ppm has been removed. Test the Storage.c fix with an alternate method. Assert that the ordinary opener rejects the negative size in the PPM file
2016-10-03 07:27:02 -07:00
wiredfool
445451c0b9
Added common check for size tuple errors
2016-10-03 07:27:02 -07:00
homm
1ba4e9e5ba
remove end of file banner from all files
2016-07-10 14:11:28 +03:00
Andrew Murray
b959a25f09
Fixed bug when saving to a non-existent path using pathlib
2016-02-27 13:10:50 +11:00
wiredfool
d965257616
Fix handling of pathlib in save. Fixes #1460
2015-10-03 08:12:44 +01:00
Andrew Murray
cf4145e2c9
Added test for pathlib
2015-08-05 21:29:24 +10:00
Andrew Murray
afa4cadb23
Added width and height properties
2015-06-26 17:20:17 +10:00
Andrew Murray
1ee1860b52
Added test for invalid image
2015-06-18 10:12:20 +10:00
Andrew Murray
ee34d6843b
Further health fixes
2015-04-24 18:24:52 +10:00
Andrew Murray
e22e4239e5
Removed unused imports
2015-04-24 16:01:47 +10:00
hugovk
9bd38bfa06
Run test_effect_noise() on non-Windows, don't be too strict
2015-03-05 23:21:42 +02:00
hugovk
8f2d707a7a
Update epsilona for hopper
2014-09-04 09:40:14 +03:00
