Commit Graph

3664 Commits

Author SHA1 Message Date
Sam Bozek
f0eba7f568 Tightening up ISSUE_Template 2016-10-28 23:21:50 -07:00
Sam Bozek
c2d2b12ef7 Tightening up ISSUE_Template 2016-10-28 23:21:32 -07:00
Matthew Honnibal
d563f1eadb Fix Issue #587: Segfault in Matcher, due to simple error in the state machine. 2016-10-28 17:42:00 +02:00
Matthew Honnibal
7e5f63a595 Improve test slightly 2016-10-28 17:41:16 +02:00
Matthew Honnibal
782e4814f4 Test Issue #587: Matcher segfaults on particular input 2016-10-28 16:38:32 +02:00
Sam Bozek
62e2615577 Merge branch 'docs' of github.com:sambozek/spaCy into docs
Commiting ISSUE_TEMPLATE.md properly.
2016-10-27 23:22:18 -07:00
Sam Bozek
1f8826e906 Tracking proper file: ISSUE_TEMPLATE.md 2016-10-27 23:19:18 -07:00
Sam Bozek
071989fd15 Renamed ISSUES.md to proper template convention of ISSUE_TEMPLATE.md 2016-10-27 23:18:38 -07:00
Sam Bozek
b2230cd7fb Renamed ISSUES.md to proper template convention of ISSUE_TEMPLATE.md 2016-10-27 23:15:55 -07:00
Sam Bozek
b66c4c3788 Formatted the steps to be in neat ordered list. Minor grammar adjustments. 2016-10-27 23:09:28 -07:00
Sam Bozek
932f4c8469 Finished ISSUES.md
* Added section for reproducing bug
	* Promote step by step reproduction of code, see if anything has been incorrectly done.
* Context section for extra details that might be helpful for issue tracking
* Final Checklist. Verify bug can be reproduced and details are present.
2016-10-27 23:03:33 -07:00
Sam Bozek
bd48d44fa7 Started work on ISSUES template.
Want to have small section to address each issue area:
* What happened/what did you expect?
* Fix suggestions/reason bug happened.
* How to reproduce for other contributors to replicate.
* Look at how workflow was affected by issue.
* As much detail as they can provide about their setup.
2016-10-27 13:46:35 -07:00
Matthew Honnibal
46ddfa8690 Merge branch 'master' of ssh://github.com/explosion/spaCy 2016-10-27 18:08:39 +02:00
Matthew Honnibal
708ea22208 Infer types in transition_system.pyx 2016-10-27 18:08:13 +02:00
Matthew Honnibal
18590eba94 Fix training evaluate method 2016-10-27 18:02:19 +02:00
Matthew Honnibal
301f3cc898 Fix Issue #429. Add an initialize_state method to the named entity recogniser that adds missing entity types. This is a messy place to add this, because it's strange to have the method mutate state. A better home for this logic could be found. 2016-10-27 18:01:55 +02:00
Matthew Honnibal
afea6505f3 Test Issue 429: No valid actions for NER after matcher adds a new entity label. 2016-10-27 18:01:34 +02:00
Matthew Honnibal
03a520ec4f Change signature of Parser.parseC, so that nr_class is read from the transition system. This allows the transition system to modify the number of actions in initialize_state. 2016-10-27 17:58:56 +02:00
Ines Montani
6bae3ec905 Merge pull request #584 from sambozek/master
Add pull request template
2016-10-27 15:27:26 +02:00
Sam Bozek
3e1dbbd52a Clarified a few statements on the pull request template.
* Added spaCy to several areas to avoid confusion
* Simplified a few statements and checkboxes.
2016-10-26 18:27:56 -07:00
Sam Bozek
63b7c2ef61 Added pull request template.
Making following assumptions:
* Pull requests do not need to originate from Issues discussion.
	* But encouraged
* No current CONTRIBUTING.md file
	* honor code that people follow current coding conventions
* Tests run and passed
	* New features require additonal tests for confirmation
2016-10-26 18:20:08 -07:00
Matthew Honnibal
21386aa68a Merge branch 'master' of ssh://github.com/explosion/spaCy 2016-10-26 17:25:13 +02:00
Matthew Honnibal
6c47048912 Fix test, after IOB tweak. 2016-10-26 17:22:03 +02:00
Matthew Honnibal
597ea8f6ac Merge pull request #582 from pokey/patch-1
Fix small bug in code of mark-adverbs tutorial
2016-10-27 01:31:50 +11:00
Pokey Rule
603a3f40c5 Fix small bug in code of mark-adverbs tutorial 2016-10-26 15:23:36 +01:00
Matthew Honnibal
271a120d30 Merge branch 'master' of ssh://github.com/explosion/spaCy 2016-10-26 13:18:21 +02:00
Matthew Honnibal
4ca31b4d87 Fix clobbering of 'missing' named ent values after assigning ents. 2016-10-26 13:13:56 +02:00
Matthew Honnibal
cb49189477 Remove dead code 2016-10-26 13:11:07 +02:00
Ines Montani
32d89ba3a2 Merge pull request #572 from lababidi/master
fix typo in url
2016-10-24 21:22:45 +02:00
Mahmoud Lababidi
f8ce28058c fix typo in url 2016-10-24 15:21:18 -04:00
Matthew Honnibal
f0a079dc0b Merge branch 'master' of ssh://github.com/explosion/spaCy 2016-10-24 20:32:06 +02:00
Matthew Honnibal
a209b10579 Improve error message when oracle fails for non-projective trees, re Issue #571. 2016-10-24 20:31:30 +02:00
Matthew Honnibal
b2d43b93d2 Fix Python 3 basestring error 2016-10-24 14:22:51 +02:00
Matthew Honnibal
276478fe0f Update strings.pxd 2016-10-24 14:00:35 +02:00
Matthew Honnibal
d8134817ff Workaround Issue #285: Allow the StringStore to be 'frozen', in which case strings will be pushed into an OOV map. We can then flush this OOV map, freeing all of the OOV strings. 2016-10-24 13:49:03 +02:00
Matthew Honnibal
d3a617aa99 Test workaround for Issue #285: Streaming data memory growth 2016-10-24 13:48:06 +02:00
Matthew Honnibal
2101ec085a Merge pull request #570 from kendricktan/master
Fixed training examples
2016-10-24 21:36:54 +11:00
kendricktan
ba8841234a Fixed training examples
Changes:
1. train_ner won't crash if no data directory is not found
2. Fixed train_tagger expected spacy.gold.GoldParse, got list
2016-10-24 16:09:23 +10:00
Matthew Honnibal
a9289f6261 Merge pull request #569 from kendricktan/master
updated training examples to v1.1.2
2016-10-24 12:57:36 +11:00
kendricktan
9877f3298f updated training examples to v1.1.2 2016-10-24 11:53:33 +10:00
Ines Montani
efaa8eaf1f Add matcher to navigation 2016-10-24 00:52:17 +02:00
Ines Montani
26dc3f3ebf Fix indentation errors 2016-10-24 00:52:17 +02:00
Ines Montani
405347b46f Fix inline code in docs 2016-10-24 00:52:17 +02:00
Ines Montani
b6fce4d82a Fix broken links in docs 2016-10-24 00:52:17 +02:00
Matthew Honnibal
2ba5141113 Merge branch 'master' of https://github.com/explosion/spaCy 2016-10-23 23:18:07 +02:00
Matthew Honnibal
105aaadc07 Make deep_learning_keras example use sentences 2016-10-23 23:17:41 +02:00
Matthew Honnibal
64e5f02cf7 Update test 2016-10-23 21:08:07 +02:00
Matthew Honnibal
66d7a6eca2 Update test 2016-10-23 21:02:05 +02:00
Matthew Honnibal
90bf797125 Update test 2016-10-23 20:54:17 +02:00
Matthew Honnibal
5e76320ffe Update test 2016-10-23 20:44:54 +02:00