Paul O'Leary McCann
3b1d5350d0
Merge pull request #8609 from mathcass/model-documentation-typo
...
Fix a command typo in models.md
2021-07-06 14:43:58 +09:00
Cass
7d13fc799b
Fix a command typo in models.md
...
"dowmload" -> "download"
2021-07-05 18:44:18 -07:00
Paul O'Leary McCann
eb5820b593
Improve take_vecs implementation
...
This pulls out references to needed bits so that other parts (the larger
embeddings) can be freed before backprop.
2021-07-05 21:08:42 +09:00
Paul O'Leary McCann
13bef2ddb6
Add width prior feature
...
Not necessary for convergence, but in coref-hoi this seems to add a few
f1 points.
Note that there are two width-related features in coref-hoi. This is a
"prior" that is added to mention scores. The other width related feature
is appended to the span embedding representation for other layers to
reference.
2021-07-05 21:06:28 +09:00
Ines Montani
218ed81f84
Add docs notes on installing models from Python and in Jupyter [ci skip] ( #8597 )
2021-07-05 13:52:15 +02:00
Ines Montani
8423864b50
Add docs notes on installing models from Python and in Jupyter [ci skip] ( #8597 )
2021-07-05 13:49:20 +02:00
Paul O'Leary McCann
8f66176b2d
Fix loss?
...
This rewrites the loss to not use the Thinc crossentropy code at all.
The main difference here is that the negative predictions are being
masked out (= marginalized over), but negative gradient is still being
reflected.
I'm still not sure this is exactly right but models seem to train
reliably now.
2021-07-05 18:17:10 +09:00
Ines Montani
f3a91b68a8
Merge pull request #8593 from yohasebe/patch-1 [ci skip]
2021-07-05 11:31:53 +10:00
Ines Montani
15108cd930
Merge pull request #8593 from yohasebe/patch-1 [ci skip]
2021-07-05 11:31:38 +10:00
Ines Montani
fdcd4003e5
Merge pull request #8592 from yohasebe/patch-2 [ci skip]
...
Adds contributor agreement yohasebe.md
2021-07-05 11:27:43 +10:00
Yoichiro Hasebe
596e04cbb4
Github repo info fixed for ruby-spacy
2021-07-04 18:55:17 +09:00
Yoichiro Hasebe
e541092088
Create yohasebe.md
2021-07-04 08:57:04 +09:00
Yoichiro Hasebe
2bdfa42107
Update universe.json
2021-07-04 08:44:39 +09:00
Paul O'Leary McCann
5db28ec2fd
Tweak mention limit calculation
...
The calculation of this in the coref-hoi code is hard to follow. Based
on comments and variable names it sounds like it's using the doc length,
but it might actually be the number of mentions? Number of mentions
should be much larger and seems more correct, but might want to revisit
this.
2021-07-03 21:13:32 +09:00
Paul O'Leary McCann
2d3c559dc4
On initialize, use just two samples
...
Coref docs are kind of long, and using 10 samples on a smallish GPU can
cause OOMs.
2021-07-03 18:43:03 +09:00
Paul O'Leary McCann
251a5b43ac
Minor fix in crossing spans code
...
I think this was technically incorrect but harmless. The reason the code
here is different than the reference in coref-hoi is that the indices
there are such that they get +1 at the end of processing, while the code
here handles indices directly.
2021-07-03 18:41:46 +09:00
Paul O'Leary McCann
865caedebd
Remove XXX comment
...
Comment wondered if there should be some subtraction to avoid double
counting, but it probably doesn't matter because the diagonal is 0.
2021-07-03 18:40:38 +09:00
Paul O'Leary McCann
d74fa82c80
Fix axis handling in topk
...
In practice this is only ever used with axis=1, so it wasn't causing
issues, even though it was wrong.
2021-07-03 18:39:25 +09:00
Paul O'Leary McCann
f2e0e9dc28
Move placeholder handling into model code
2021-07-03 18:38:48 +09:00
Paul O'Leary McCann
3f66e18592
Clean up pw_prod loss
...
This doesn't change the math but makes the transposes slightly easier to
understand (maybe?).
2021-07-03 18:33:17 +09:00
Ines Montani
3dcb747980
Merge pull request #8580 from explosion/autoblack
...
Auto-format code with black
2021-07-03 13:15:07 +10:00
explosion-bot
ee37288a1f
Auto-format code with black
2021-07-02 07:48:26 +00:00
Ines Montani
c5c4e96597
Fix syntax [ci skip]
2021-07-02 17:46:56 +10:00
Ines Montani
6b905d67df
Try workflow_dispatch and schedule [ci skip]
2021-07-02 17:45:27 +10:00
Ines Montani
70589e348e
Commit as explosion-bot [ci skip]
2021-07-02 17:45:11 +10:00
Ines Montani
dd34a3a433
Try simpler approach [ci skip]
2021-07-02 17:40:49 +10:00
Ines Montani
2898331494
Improve logic [ci skip]
2021-07-02 17:37:35 +10:00
Ines Montani
519a9e29be
Fix git login [ci skip]
2021-07-02 17:30:59 +10:00
Ines Montani
8961f36415
Commit manually in workflow [ci skip]
2021-07-02 17:27:48 +10:00
Ines Montani
2a5cbf1b0c
Test different workflow trigger [ci skip]
2021-07-02 17:22:43 +10:00
Ines Montani
bbbaae0b5e
Update triggers [ci skip]
2021-07-02 17:10:24 +10:00
Ines Montani
cdefb8cf1b
Experimental: add autoblack.yml action [ci skip]
2021-07-02 17:07:05 +10:00
julien-talkair
6b1f9a5be0
add spacy contributor agreement
2021-07-01 17:41:12 +02:00
julien-talkair
a0004349f3
🎉 run code quality checks automatically
...
* installs black and flake8 as pre-commit hooks
* runs only on modified files
2021-07-01 17:37:43 +02:00
Adriane Boyd
2fc67e2aeb
Require thinc >=8.0.7 ( #8572 )
2021-07-01 16:55:09 +02:00
Suqi Sun
3901507df8
Update pip
2021-06-30 16:44:43 -04:00
Suqi Sun
61c868ed75
Update pip and code example
2021-06-30 14:49:51 -04:00
Ines Montani
af9d984407
Merge pull request #8405 from svlandeg/fix/whitespace_tokenizer [ci skip]
2021-06-30 20:52:59 +10:00
Adriane Boyd
2b8c679a3d
Fix duplicate spacy package CLI opts ( #8551 )
...
Use `-c` for `--code` and not additionally for `--create-meta`, in line
with the docs.
2021-06-30 11:23:26 +02:00
Suqi Sun
4331c40b78
Add forte to universe.json
2021-06-29 16:17:22 -04:00
Adriane Boyd
41292a1b84
Add note about updating with fill-config
2021-06-29 10:45:36 +02:00
Nick Sorros
bb781ae7f7
Remove extra parenthesis from the example for spacy-streamlit ( #8527 )
2021-06-28 14:03:31 +02:00
Ines Montani
7f65902702
Merge pull request #8522 from adrianeboyd/chore/update-flake8
...
Update flake8 version in reqs and CI
2021-06-28 21:46:06 +10:00
Ines Montani
8bc235dcc0
Merge pull request #8523 from adrianeboyd/chore/cleanup-v3.1.0
2021-06-28 21:45:38 +10:00
Adriane Boyd
86d01e9229
Tidy up with flake8: imports, comparisons, etc.
2021-06-28 12:08:15 +02:00
Adriane Boyd
4d1ef8f695
Tidy up docs
2021-06-28 12:08:15 +02:00
Adriane Boyd
5eeb25f043
Tidy up code
2021-06-28 12:08:15 +02:00
Adriane Boyd
4b0ed73ed4
Update flake8 version in reqs and CI
...
* Update some unneeded forward refs related to flake8 checks
2021-06-28 11:29:36 +02:00
Paul O'Leary McCann
b02df61eb9
Add test for crossing spans
...
This should maybe go elsewhere?
2021-06-28 18:21:00 +09:00
Paul O'Leary McCann
4f377d8de8
Fix bug in crossing span detection
2021-06-28 18:20:33 +09:00
